feat: services stage + Make→Task/mise migration + README overhaul - #11
Merged
Conversation
Replace the Makefile with a Taskfile.yml (same targets: build/test/vet, e2e-disks-light/full, vm/vm-fresh/vm-disk) and add mise.toml to provision Go + task. Update the e2e-disks workflow comments to reference `task` instead of `make`, and allow the new tooling commands in settings.local.json. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Restructure the README around the two-phase model with a table-of-contents, a per-key configuration reference, a stages table, and expanded VM-testing / contributor sections. Also documents the new services stage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
New Phase B stage (order 90, runs last after dotfiles + setup) that `systemctl enable`s the units in a new `services:` config block so they start on the next boot — e.g. a login/display-manager unit like plasmalogin.service. `enable` lists system units (enabled as root) and `user` lists per-user units (enabled with `systemctl --user`). Enabling is idempotent and unset leaves services untouched, so existing configs and golden snapshots are unaffected. Units are enabled, not --now-started, to avoid restarting a display manager underneath the current session. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles three independent working-tree changes onto one branch (three commits).
1.
feat: services stage (Phase B, order 90)New stage that runs last in Phase B and
systemctl enables the units in a newservices:config block so they start on the next boot — e.g. a login/display-manager unit likeplasmalogin.service.--now-started — the typical case is a display manager that should take over on reboot, not be started underneath the current session.services_test.go(system+user, system-only, empty-skip); registry/--fromwindow tests updated.2.
chore: build tooling — Make → Task + miseReplaces the
MakefilewithTaskfile.yml(identical targets) and addsmise.tomlto provision Go + task. Workflow comments andsettings.local.jsonupdated to match.3.
docs: README overhaulRestructures the README around the two-phase model with a table-of-contents, per-key configuration reference, stages table, and expanded VM-testing/contributor sections. Also documents the new services stage.
Testing
gofmt -l .clean,go build,go vet ./...,go test ./...all pass.🤖 Generated with Claude Code